Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torrent support #1620

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Torrent support #1620

wants to merge 16 commits into from

Conversation

Diegopyl1209
Copy link
Contributor

This implement TorrServer in Aniyomi

Changes:

  • Added torrent streaming support
  • Added torrent support in local source
  • Added support for downloading torrents

Streaming demo:
https://github.com/aniyomiorg/aniyomi/assets/80992641/e9a00a77-ada5-4f6d-a7dd-1ed4446cb63c

Download demo:
https://github.com/aniyomiorg/aniyomi/assets/80992641/4fae6de8-3aaa-4059-863f-777c43dc9efe

@Diegopyl1209 Diegopyl1209 changed the title Torrent Torrent support Jun 20, 2024
@Sadwhy
Copy link

Sadwhy commented Jun 20, 2024

How much does this increase app size?

abdallahmehiz
abdallahmehiz reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@abdallahmehiz abdallahmehiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not upload the compiled libraries to something like Jitpack or Sonatype?

@Diegopyl1209
Copy link
Contributor Author

Why not upload the compiled libraries to something like Jitpack or Sonatype?
👍

abdallahmehiz
abdallahmehiz reviewed Jun 21, 2024
View reviewed changes
app/src/main/java/eu/kanade/tachiyomi/data/torrentServer/TorrentServerPreferences.kt
fun port() = preferenceStore.getString("pref_torrent_port", "8090")

fun trackers() = preferenceStore.getString(
"pref_torrent_trackers",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmir1 will have to check this...

@Diegopyl1209
Copy link
Contributor Author

btw idk why the build is failing aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa i made the exact same pr in my repo and the same gh action work fine , i also clone the repo in my machine and works fine

@Secozzi
Copy link
Contributor

Secozzi commented Jun 22, 2024

btw idk why the build is failing aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa i made the exact same pr in my repo and the same gh action work fine , i also clone the repo in my machine and works fine

Your aniyomi repo is probably outdated then, since it doesn't include my merge from mihon where I moved :core to :core:common

To fix this, do import tachiyomi.core.common.i18n.stringResource instead of import tachiyomi.core.i18n.stringResource etc etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntsyLich AntsyLich AntsyLich left review comments

@abdallahmehiz abdallahmehiz abdallahmehiz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Diegopyl1209 @Sadwhy @Secozzi @abdallahmehiz @AntsyLich